ES6 template literals: Fix issue with template after rbrace

ES6 template literals: Fix issue with template after rbrace

If we hade }` the right brace was always treated as part of the
template literal. We should only treat the right brace as part of
the literal when we continue to parse the template literal after a
placeholder.

BUG=v8:3734
LOG=Y

[arv (Not doing code reviews), 2014-12-03 22:58:11]

Fix test

[arv (Not doing code reviews), 2014-12-03 22:59:04]

Patchset #1 (id:1) has been deleted

[arv (Not doing code reviews), 2014-12-03 23:00:30]

Self review

[arv (Not doing code reviews), 2014-12-03 23:13:25]

Remove need for PushBack

[arv (Not doing code reviews), 2014-12-03 23:16:58]

arv@chromium.org changed reviewers:
+ marja@chromium.org

[arv (Not doing code reviews), 2014-12-03 23:16:59]

PTAL

[caitp (gmail), 2014-12-03 23:20:24]

caitpotter88@gmail.com changed reviewers:
+ caitpotter88@gmail.com

[caitp (gmail), 2014-12-03 23:20:25]

lgtm, thanks for finding this!

https://codereview.chromium.org/778813003/diff/60001/test/mjsunit/harmony/tem...
File test/mjsunit/harmony/templates.js (right):

https://codereview.chromium.org/778813003/diff/60001/test/mjsunit/harmony/tem...
test/mjsunit/harmony/templates.js:461: `abc`;
So "function f() {}`abc`;" would have failed before too, but should work now. No
pressure but it might not hurt to add that line as well, extra-redundant or
something

[arv (Not doing code reviews), 2014-12-03 23:25:29]

On 2014/12/03 23:20:25, caitp wrote:
> lgtm, thanks for finding this!
> 
>
https://codereview.chromium.org/778813003/diff/60001/test/mjsunit/harmony/tem...
> File test/mjsunit/harmony/templates.js (right):
> 
>
https://codereview.chromium.org/778813003/diff/60001/test/mjsunit/harmony/tem...
> test/mjsunit/harmony/templates.js:461: `abc`;
> So "function f() {}`abc`;" would have failed before too, but should work now.
No
> pressure but it might not hurt to add that line as well, extra-redundant or
> something

I'll add tests without new lines since it does not hurt to be more explicit.

[arv (Not doing code reviews), 2014-12-03 23:28:24]

Add tests without newlines

[arv (Not doing code reviews), 2014-12-04 13:49:47]

arv@chromium.org changed reviewers:
+ dslomov@chromium.org

[arv (Not doing code reviews), 2014-12-04 13:49:47]

Dmitry, since you landed the staging CL, this bug might be triggered by the
fuzzer (if the fuzzer even creates template literals?)

[Dmitry Lomov (no reviews), 2014-12-04 14:23:47]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2014-12-04 14:23:48]

lgtm

[commit-bot: I haz the power, 2014-12-04 14:24:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/778813003/80001

[commit-bot: I haz the power, 2014-12-04 14:50:15]

Committed patchset #4 (id:80001)