Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 778753002: Remove PaintLayerPaintingOverflowContents. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
eseidel
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove PaintLayerPaintingOverflowContents. It was added for compositing overflow:scroll, which we don't do. This also means that only the RespectOverflowClip enum value is used. And PaintingClipRectsIgnoringOverflowClip is unused. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ba4ea7b78e00faec3e6d0a9d403dfaf791d23211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -49 lines) Patch
M sky/engine/core/rendering/ClipRectsCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/LayerPaintingInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 7 chunks +5 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerClipper.h View 2 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerClipper.cpp View 3 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eseidel
lgtm
6 years ago (2014-12-03 20:51:13 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-03 20:54:24 UTC) #5
ojan
6 years ago (2014-12-04 03:10:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ba4ea7b78e00faec3e6d0a9d403dfaf791d23211.

Powered by Google App Engine
This is Rietveld 408576698