Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp - Issue 778703004: Implement ServiceWorkerClient attributes [3/3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 778703004: Implement ServiceWorkerClient attributes [3/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@properties-step1

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/clients-getall.html ('K') | « Source/modules/serviceworkers/ServiceWorkerClients.cpp ('k') | public/platform/WebServiceWorkerClientsInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

index 22a0b49f9e25fab4c839e89b75750be9a651df11..a90b1fd60f93ad71fff9549bcae617799107a467 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

@@ -373,7 +373,7 @@ TEST_F(ServiceWorkerContainerTest, GetRegistration_OmittedDocumentURLDefaultsToP

TEST_F(ServiceWorkerContainerTest, GetClientInfo)

{

- setVisibilityState(PageVisibilityStateVisible);

+ setVisibilityState(PageVisibilityStateHidden);

setFocused(true);

setPageURL("http://localhost/x/index.html");

@@ -381,7 +381,7 @@ TEST_F(ServiceWorkerContainerTest, GetClientInfo)

WebServiceWorkerClientInfo info;

ASSERT_TRUE(container->getClientInfo(&info));

- EXPECT_EQ(WebString("visible"), info.visibilityState);

+ EXPECT_EQ(WebString("hidden"), info.visibilityState);

EXPECT_TRUE(info.isFocused);

EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/index.html")), info.url);

EXPECT_EQ(WebURLRequest::FrameTypeTopLevel, info.frameType);

nhiroki 2014/12/08 08:01:09 How about calling setVisibilityState(Visible) and

Kunihiko Sakamoto 2014/12/08 08:34:10 Done.