Do not embed function in DirectLoadGlobalFunctionPrototype.

Do not embed function in DirectLoadGlobalFunctionPrototype.

BUG=v8:3629
LOG=N

[ulan, 2014-12-03 16:10:38]

ulan@chromium.org changed reviewers:
+ verwaest@chromium.org

[ulan, 2014-12-03 16:10:38]

PTAL

[Toon Verwaest, 2014-12-03 16:22:09]

https://codereview.chromium.org/778673002/diff/1/src/ic/arm64/handler-compile...
File src/ic/arm64/handler-compiler-arm64.cc (right):

https://codereview.chromium.org/778673002/diff/1/src/ic/arm64/handler-compile...
src/ic/arm64/handler-compiler-arm64.cc:73: __ CmpWeakValue(function, cell,
scratch);
Why still embed the weak cell if all you do is miss if it's different? We'll do
a map-check on the prototype itself anyway later on if we use it, so checking
the function itself is not necessary as far as I can tell.

[ulan, 2014-12-03 16:49:59]

On 2014/12/03 16:22:09, Toon Verwaest wrote:
>
https://codereview.chromium.org/778673002/diff/1/src/ic/arm64/handler-compile...
> File src/ic/arm64/handler-compiler-arm64.cc (right):
> 
>
https://codereview.chromium.org/778673002/diff/1/src/ic/arm64/handler-compile...
> src/ic/arm64/handler-compiler-arm64.cc:73: __ CmpWeakValue(function, cell,
> scratch);
> Why still embed the weak cell if all you do is miss if it's different? We'll
do
> a map-check on the prototype itself anyway later on if we use it, so checking
> the function itself is not necessary as far as I can tell.

Good point! The function isn't used later, so we can indeed omit checking
function.
I uploaded new patch set and will change the description.

[Toon Verwaest, 2014-12-03 17:09:11]

lgtm

[ulan, 2014-12-04 10:26:08]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2014-12-04 10:27:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/778673002/40001

[commit-bot: I haz the power, 2014-12-04 10:52:45]

Committed patchset #3 (id:40001)