Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 778643012: Get the Syzygy binaries from an https server. (Closed)

Created:
6 years ago by Sébastien Marchand
Modified:
6 years ago
Reviewers:
chrisha
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Get the Syzygy binaries from an https server. BUG= Committed: https://crrev.com/4e8e135c7016b2bf676da596234de478e0f6a89a Cr-Commit-Position: refs/heads/master@{#306886}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Revert the changes in tools/win/sizeviewer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/get_syzygy_binaries.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Sébastien Marchand
PTAL
6 years ago (2014-12-04 16:31:16 UTC) #2
chrisha
lgtm
6 years ago (2014-12-04 18:34:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778643012/1
6 years ago (2014-12-04 18:35:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/39088) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/34669)
6 years ago (2014-12-04 18:38:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778643012/20001
6 years ago (2014-12-04 19:53:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/90051) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/94616) chromium_presubmit ...
6 years ago (2014-12-04 19:56:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778643012/40001
6 years ago (2014-12-04 20:13:35 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-04 21:00:01 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-04 21:00:54 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4e8e135c7016b2bf676da596234de478e0f6a89a
Cr-Commit-Position: refs/heads/master@{#306886}

Powered by Google App Engine
This is Rietveld 408576698