Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1739)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 778643003: aw: Add more trace events to drawing functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/browser/deferred_gpu_command_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index 94bf53ab3caee10407c8ea5f207d1bab6a17f095..5b4e8b09563f8aba817e049db8430cbf0f2352e5 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -144,16 +144,23 @@ void BrowserViewRenderer::PrepareToDraw(const gfx::Vector2d& scroll,
bool BrowserViewRenderer::OnDrawHardware() {
TRACE_EVENT0("android_webview", "BrowserViewRenderer::OnDrawHardware");
shared_renderer_state_.InitializeHardwareDrawIfNeededOnUI();
- if (!compositor_)
+ if (!compositor_) {
+ TRACE_EVENT_INSTANT0("android_webview", "EarlyOut_NoCompositor",
+ TRACE_EVENT_SCOPE_THREAD);
return false;
+ }
shared_renderer_state_.SetScrollOffsetOnUI(last_on_draw_scroll_offset_);
if (!hardware_enabled_) {
+ TRACE_EVENT0("android_webview", "InitializeHwDraw");
hardware_enabled_ = compositor_->InitializeHwDraw();
}
- if (!hardware_enabled_)
+ if (!hardware_enabled_) {
+ TRACE_EVENT_INSTANT0("android_webview", "EarlyOut_HardwareNotEnabled",
+ TRACE_EVENT_SCOPE_THREAD);
return false;
+ }
if (last_on_draw_global_visible_rect_.IsEmpty() &&
parent_draw_constraints_.surface_rect.IsEmpty()) {
@@ -174,8 +181,11 @@ bool BrowserViewRenderer::OnDrawHardware() {
}
scoped_ptr<cc::CompositorFrame> frame = CompositeHw();
- if (!frame.get())
+ if (!frame.get()) {
+ TRACE_EVENT_INSTANT0("android_webview", "NoNewFrame",
+ TRACE_EVENT_SCOPE_THREAD);
return false;
+ }
shared_renderer_state_.SetCompositorFrameOnUI(frame.Pass(), false);
return true;
« no previous file with comments | « no previous file | android_webview/browser/deferred_gpu_command_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698