Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: Source/core/dom/Node.h

Issue 778643002: Oilpan: prevent eager tracing of Node and RenderObjects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved. 5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 : m_renderer(renderer) 107 : m_renderer(renderer)
108 { } 108 { }
109 109
110 protected: 110 protected:
111 // Oilpan: This member is traced in NodeRareData. 111 // Oilpan: This member is traced in NodeRareData.
112 // FIXME: Can we add traceAfterDispatch and finalizeGarbageCollectedObject 112 // FIXME: Can we add traceAfterDispatch and finalizeGarbageCollectedObject
113 // to NodeRareDataBase, and make m_renderer Member<>? 113 // to NodeRareDataBase, and make m_renderer Member<>?
114 RenderObject* m_renderer; 114 RenderObject* m_renderer;
115 }; 115 };
116 116
117 class Node;
118 WILL_NOT_BE_EAGERLY_TRACED_CLASS(Node);
119
117 #if ENABLE(OILPAN) 120 #if ENABLE(OILPAN)
118 #define NODE_BASE_CLASSES public GarbageCollectedFinalized<Node>, public EventTa rget 121 #define NODE_BASE_CLASSES public GarbageCollectedFinalized<Node>, public EventTa rget
119 #else 122 #else
120 // TreeShared should be the last to pack TreeShared::m_refCount and 123 // TreeShared should be the last to pack TreeShared::m_refCount and
121 // Node::m_nodeFlags on 64bit platforms. 124 // Node::m_nodeFlags on 64bit platforms.
122 #define NODE_BASE_CLASSES public EventTarget, public TreeShared<Node> 125 #define NODE_BASE_CLASSES public EventTarget, public TreeShared<Node>
123 #endif 126 #endif
124 127
125 class Node : NODE_BASE_CLASSES { 128 class Node : NODE_BASE_CLASSES {
126 DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(TreeShared<Node>); 129 DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(TreeShared<Node>);
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 } // namespace blink 897 } // namespace blink
895 898
896 #ifndef NDEBUG 899 #ifndef NDEBUG
897 // Outside the WebCore namespace for ease of invocation from gdb. 900 // Outside the WebCore namespace for ease of invocation from gdb.
898 void showNode(const blink::Node*); 901 void showNode(const blink::Node*);
899 void showTree(const blink::Node*); 902 void showTree(const blink::Node*);
900 void showNodePath(const blink::Node*); 903 void showNodePath(const blink::Node*);
901 #endif 904 #endif
902 905
903 #endif // Node_h 906 #endif // Node_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698