Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 77863005: Make refcounting of IndexedDBFactory threadsafe (Closed)

Created:
7 years, 1 month ago by jsbell
Modified:
7 years, 1 month ago
CC:
chromium-reviews, jsbell, jam, alecflett, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan
Visibility:
Public.

Description

Make refcounting of IndexedDBFactory threadsafe When IndexedDBContext is destroyed it posts a task to the IDB thread to run IndexedDBFactory::ContextDestroyed() to do some cleanup, but drops its own reference, leading to a refcounting/threading race. Follow the rules in base/callbacks.h to use RefCountedThreadSafe<> to fix. R=alecflett,dgrogan TBR=glider BUG=321596 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236842

Patch Set 1 #

Patch Set 2 : Remove suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M content/browser/indexed_db/indexed_db_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/valgrind/tsan_v2/suppressions.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
alecflett@, dgrogan@, glider@ - please take a look? I'm having trouble reproducing w/ tsan (always ...
7 years, 1 month ago (2013-11-20 20:02:58 UTC) #1
alecflett
lgtm
7 years, 1 month ago (2013-11-22 18:13:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/77863005/30001
7 years, 1 month ago (2013-11-22 18:15:08 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=37683
7 years, 1 month ago (2013-11-22 18:37:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/77863005/30001
7 years, 1 month ago (2013-11-22 19:48:57 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 22:21:11 UTC) #6
Message was sent while issue was closed.
Change committed as 236842

Powered by Google App Engine
This is Rietveld 408576698