LayoutTests/fast/dom/shadow/shadow-element-add-child-dynamically.html - Issue 77863002: Update styleRecalc so that it traverses shadow insertion points in 2 pass algorithms

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/shadow/shadow-element-add-child-dynamically.html

Issue 77863002: Update styleRecalc so that it traverses shadow insertion points in 2 pass algorithms (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 if (window.testRunner)

	6 testRunner.waitUntilDone();

	7

	8 function test() {

	9 var host = document.querySelector("#host");

	10 var olderShadowRoot = host.createShadowRoot();

	11 olderShadowRoot.appendChild(document.createElement("content"));

	12 var youngerShadowRoot = host.createShadowRoot();

	13 var shadow = document.createElement("shadow");

	14 var shadowChild = document.createElement("div");

	15 youngerShadowRoot.appendChild(shadow);

	16 shadow.appendChild(shadowChild);

	17 shadowChild.appendChild(document.createTextNode('CHILD1'));

	18

	19 function addChild() {

	20 shadowChild.appendChild(document.createTextNode('CHILD2'));

	21 if (window.testRunner)

	22 testRunner.notifyDone();

	23 }

	24

	25 setTimeout(addChild, 0);
	esprehn 2013/11/20 09:22:23 Why setTimeout? Are you assuming that a recalcStyl Why setTimeout? Are you assuming that a recalcStyle happened between? There's no guarantee that will happen and this test will be flakily testing the thing you want it to test. You should touch offsetTop of something or use getComputedStyle to trigger a recalc and not make this an async test.
	26 }

	27 </script>

	28 </head>

	29 <body onload="test()">

	30 <div title="requiresThisElementToReproduce"><div id='host'></div></div>

	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/shadow/shadow-element-add-child-dynamically-expected.html » ('j') | no next file with comments »