Add sanity check to generateKey to make sure usages aren't empty

content/child/webcrypto/algorithm_dispatch.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_WEBCRYPTO_ALGORITHM_DISPATCH_H_
 #define CONTENT_CHILD_WEBCRYPTO_ALGORITHM_DISPATCH_H_
 
 #include <stdint.h>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
+#include "content/child/webcrypto/generate_key_result.h"

[eroman, 2014/12/05 19:41:55]

Please move the header to the .cc file and leave this file unchanged.

In Chromium we prefer to use forward declarations to reduce header bloat from
slowing down compiles (headers in C++ are not very efficient)

[nharper, 2014/12/05 23:15:47]

Done.

 #include "content/common/content_export.h"
 #include "third_party/WebKit/public/platform/WebCrypto.h"
 
 namespace content {
 
 namespace webcrypto {
 
 class AlgorithmImplementation;
 class CryptoData;
-class GenerateKeyResult;
 class Status;
 
 // These functions provide an entry point for synchronous webcrypto operations.
 //
 // The inputs to these methods come from Blink, and hence the validations done
 // by Blink can be assumed:
 //
 //   * The algorithm parameters are consistent with the algorithm
 //   * The key contains the required usage for the operation
 
@@ skipping 72 matching lines @@
     bool extractable,
     blink::WebCryptoKeyUsageMask usages,
     const CryptoData& key_data,
     blink::WebCryptoKey* key);
 
 }  // namespace webcrypto
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_WEBCRYPTO_ALGORITHM_DISPATCH_H_