Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 778513003: gn: Employ the same INSERT_VARIABLE macro trick for switches.cc (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn: Employ the same INSERT_VARIABLE macro trick for switches.cc This applies the macro trick used in variables.cc to clean up GetSwitches() function. BUG=None R=brettw@chromium.org Committed: https://crrev.com/d00cdf71c4e5ab4aa73cfa5f251a526e60cc2aba Cr-Commit-Position: refs/heads/master@{#306691}

Patch Set 1 #

Total comments: 2

Patch Set 2 : empty string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M tools/gn/switches.cc View 1 2 chunks +20 lines, -15 lines 0 comments Download
M tools/gn/variables.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tfarina
6 years ago (2014-12-03 01:00:44 UTC) #1
brettw
https://codereview.chromium.org/778513003/diff/1/tools/gn/switches.cc File tools/gn/switches.cc (right): https://codereview.chromium.org/778513003/diff/1/tools/gn/switches.cc#newcode169 tools/gn/switches.cc:169: : short_help(NULL), I'm not sure we want to change ...
6 years ago (2014-12-03 17:57:33 UTC) #2
tfarina
https://codereview.chromium.org/778513003/diff/1/tools/gn/switches.cc File tools/gn/switches.cc (right): https://codereview.chromium.org/778513003/diff/1/tools/gn/switches.cc#newcode169 tools/gn/switches.cc:169: : short_help(NULL), On 2014/12/03 17:57:33, brettw wrote: > I'm ...
6 years ago (2014-12-03 20:56:24 UTC) #3
brettw
lgtm
6 years ago (2014-12-03 21:02:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778513003/20001
6 years ago (2014-12-03 21:03:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 22:29:15 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-03 22:30:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d00cdf71c4e5ab4aa73cfa5f251a526e60cc2aba
Cr-Commit-Position: refs/heads/master@{#306691}

Powered by Google App Engine
This is Rietveld 408576698