Replace #define syscalls cancel machinery.

Replace #define syscalls cancel machinery.

Use inline functions for type-checking. Separate CL will allow
user to redefine/catch these functions.

R=pasko@google.com

Committed: http://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=ca3390c

[pasko-google - do not use, 2011-09-02 16:25:24]

LGT

mostly agreed, though the amounts of adapter functions scare me, I could not
verify the parameter types and order

it's good that this is all in a separate change

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/futex_emulation.c
File sysdeps/nacl/futex_emulation.c (right):

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/futex_emulation...
sysdeps/nacl/futex_emulation.c:261: retcode = nacl_futex_wake_nolock (addr1,
nwake, __FUTEX_BITSET_MATCH_ANY, count);
line too long

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/irt_syscalls.h
File sysdeps/nacl/irt_syscalls.h (right):

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/irt_syscalls.h#...
sysdeps/nacl/irt_syscalls.h:84: #include <linux/posix_types.h>
minor: plz, group linear part of includes together, and visibly separate

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h
File sysdeps/nacl/sysdep.h (right):

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcode10
sysdeps/nacl/sysdep.h:10: don't hard code the value of ENOSYS. */
this TODO is obsolete, please, remove

we should clarify somehow what we are doing:

/* Implementation of all syscalls for use in platform- and OS- independent code
   as inline functions.  Each function translates the syscall arguments into IRT
   arguments and allows to intercept each call in user code.
   TODO(khim): implement the interception logic.  */

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcode21
sysdeps/nacl/sysdep.h:21: (*err) = (38 /* ENOSYS */);
no need for round brackets

why not just #define ENOSYS 38
?

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcod...
sysdeps/nacl/sysdep.h:223: switch
(futex_operation.decoded_futex_operation.operation)
switch? why?
this is easier to read:

if (blah == FUTEX_UNLOCK_PI)
  {
    *err = ENOSYS;
    return;
  }
if (__builtin_constant_p (...))
  __futex_emulation_unknown_operation ();
*err = 0;

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcod...
sysdeps/nacl/sysdep.h:1234: #define INTERNAL_SYSCALL_ERRNO(val, err) err
(err)

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcod...
sysdeps/nacl/sysdep.h:1237: #define INTERNAL_SYSCALL_ERROR_P(val, err) err
(err)

[pasko-google - do not use, 2011-09-02 16:25:41]

I mean, LGTM

[khim, 2011-09-02 16:36:09]

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/futex_emulation.c
File sysdeps/nacl/futex_emulation.c (right):

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/futex_emulation...
sysdeps/nacl/futex_emulation.c:261: retcode = nacl_futex_wake_nolock (addr1,
nwake, __FUTEX_BITSET_MATCH_ANY, count);
On 2011/09/02 16:25:24, pasko wrote:
> line too long

Done.

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/irt_syscalls.h
File sysdeps/nacl/irt_syscalls.h (right):

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/irt_syscalls.h#...
sysdeps/nacl/irt_syscalls.h:84: #include <linux/posix_types.h>
On 2011/09/02 16:25:24, pasko wrote:
> minor: plz, group linear part of includes together, and visibly separate

Done.

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h
File sysdeps/nacl/sysdep.h (right):

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcode10
sysdeps/nacl/sysdep.h:10: don't hard code the value of ENOSYS. */
On 2011/09/02 16:25:24, pasko wrote:
> this TODO is obsolete, please, remove
> 
> we should clarify somehow what we are doing:
> 
> /* Implementation of all syscalls for use in platform- and OS- independent
code
>    as inline functions.  Each function translates the syscall arguments into
IRT
>    arguments and allows to intercept each call in user code.
>    TODO(khim): implement the interception logic.  */

Done.

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcode21
sysdeps/nacl/sysdep.h:21: (*err) = (38 /* ENOSYS */);
Because it's sometimes defined as "12" (from NaCl headers) and sometimes as "38"
(Linux).

This is a mess, but this CL is already too big to try to fit cleanup logic here.

Round brackets will make search/and/replace work easier.

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcod...
sysdeps/nacl/sysdep.h:223: switch
(futex_operation.decoded_futex_operation.operation)
All other functions use switch.

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcod...
sysdeps/nacl/sysdep.h:1234: #define INTERNAL_SYSCALL_ERRNO(val, err) err
On 2011/09/02 16:25:24, pasko wrote:
> (err)

Done.

http://codereview.chromium.org/7785030/diff/9002/sysdeps/nacl/sysdep.h#newcod...
sysdeps/nacl/sysdep.h:1237: #define INTERNAL_SYSCALL_ERROR_P(val, err) err
On 2011/09/02 16:25:24, pasko wrote:
> (err)

Done.