Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: src/extensions/externalize-string-extension.cc

Issue 7785027: Make a static non-POD object a static raw pointer instead. (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/extensions/externalize-string-extension.cc
diff --git a/src/extensions/externalize-string-extension.cc b/src/extensions/externalize-string-extension.cc
index b3f83fe98dfdb9f5d6183d3585345cc44f6487c4..98b198a048a4a63090663579913b4c04c798ecac 100644
--- a/src/extensions/externalize-string-extension.cc
+++ b/src/extensions/externalize-string-extension.cc
@@ -133,9 +133,11 @@ v8::Handle<v8::Value> ExternalizeStringExtension::IsAscii(
void ExternalizeStringExtension::Register() {
- static ExternalizeStringExtension externalize_extension;
+ static ExternalizeStringExtension* externalize_extension;
mnaganov (inactive) 2011/08/31 14:04:48 For clarity, please initialize with NULL.
tfarina 2011/08/31 19:04:00 Done.
+ if (!externalize_extension)
mnaganov (inactive) 2011/08/31 14:04:48 externalize_extension == NULL
tfarina 2011/08/31 19:04:00 Done.
+ externalize_extension = new ExternalizeStringExtension;
static v8::DeclareExtension externalize_extension_declaration(
tfarina 2011/08/31 13:54:21 Mad why we do this with externalize_extension_decl
- &externalize_extension);
+ externalize_extension);
}
} } // namespace v8::internal
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698