Issue 7785027: Make a static non-POD object a static raw pointer instead.

Issue 7785027: Make a static non-POD object a static raw pointer instead. (Closed)

Created:
9 years, 3 months ago by tfarina

Modified:
9 years, 3 months ago

Reviewers:
mnaganov (inactive), Mads Ager (chromium)

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

Description

Make a static non-POD object a static raw pointer instead. Change it to a plain static pointer and initialize lazy. BUG=83856 TEST=None R=ager@chromium.org,mnaganov@chromium.org Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://code.google.com/p/v8/source/detail?r=9120

Patch Set 2 : mnaganov review #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/extensions/externalize-string-extension.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tfarina

Mad for review (original author). Mikhail fyi (if you want to commit this to me ...

9 years, 3 months ago (2011-08-31 13:54:21 UTC) #1

mnaganov (inactive)

http://codereview.chromium.org/7785027/diff/1/src/extensions/externalize-string-extension.cc File src/extensions/externalize-string-extension.cc (right): http://codereview.chromium.org/7785027/diff/1/src/extensions/externalize-string-extension.cc#newcode136 src/extensions/externalize-string-extension.cc:136: static ExternalizeStringExtension* externalize_extension; For clarity, please initialize with NULL. ...

9 years, 3 months ago (2011-08-31 14:04:48 UTC) #2

tfarina

9 years, 3 months ago (2011-08-31 19:04:00 UTC) #3

mnaganov (inactive)

LGTM Thanks for fixing this! On 2011/08/31 19:04:00, tfarina wrote: > http://codereview.chromium.org/7785027/diff/1/src/extensions/externalize-string-extension.cc > File src/extensions/externalize-string-extension.cc ...

9 years, 3 months ago (2011-09-01 13:31:21 UTC) #4

tfarina

On 2011/09/01 13:31:21, Mikhail Naganov (Chromium) wrote: > LGTM > > Thanks for fixing this! ...

9 years, 3 months ago (2011-09-02 15:42:47 UTC) #5

mnaganov (inactive)

9 years, 3 months ago (2011-09-02 16:42:07 UTC) #6

On 2011/09/02 15:42:47, tfarina wrote:
> On 2011/09/01 13:31:21, Mikhail Naganov (Chromium) wrote:
> > LGTM
> > 
> > Thanks for fixing this!
> > 
> Could you land this to me?
> 
> > On 2011/08/31 19:04:00, tfarina wrote:
> > >
> >
>
http://codereview.chromium.org/7785027/diff/1/src/extensions/externalize-stri...
> > > File src/extensions/externalize-string-extension.cc (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/7785027/diff/1/src/extensions/externalize-stri...
> > > src/extensions/externalize-string-extension.cc:136: static
> > > ExternalizeStringExtension* externalize_extension;
> > > On 2011/08/31 14:04:48, Mikhail Naganov (Chromium) wrote:
> > > > For clarity, please initialize with NULL.
> > > 
> > > Done.
> > > 
> > >
> >
>
http://codereview.chromium.org/7785027/diff/1/src/extensions/externalize-stri...
> > > src/extensions/externalize-string-extension.cc:137: if
> > (!externalize_extension)
> > > On 2011/08/31 14:04:48, Mikhail Naganov (Chromium) wrote:
> > > > externalize_extension == NULL
> > > 
> > > Done.

Of course! Sorry, for some reason I've thought it's for Chromium code :)

Expand Messages | Collapse Messages