components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h - Issue 778463002: Wrapped data reduction proxy initialization into its own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

Issue 778463002: Wrapped data reduction proxy initialization into its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@network-delegate

Patch Set: Addressed comment from mmenke Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

index 17dc32f9f52a5e7c9ea2434f3673d1f12fc1deb5..2f5f370cb618cf7e1ef66d9f58b06b3db6368724 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

@@ -38,6 +38,7 @@ class URLRequest;

namespace data_reduction_proxy {

class DataReductionProxyAuthRequestHandler;

+class DataReductionProxyConfigurator;

class DataReductionProxyParams;

class DataReductionProxyStatisticsPrefs;

class DataReductionProxyUsageStats;

@@ -74,7 +75,7 @@ class DataReductionProxyNetworkDelegate : public net::LayeredNetworkDelegate {

scoped_ptr<net::NetworkDelegate> network_delegate,

DataReductionProxyParams* params,

DataReductionProxyAuthRequestHandler* handler,

- const ProxyConfigGetter& getter);

+ const DataReductionProxyConfigurator* configurator);

~DataReductionProxyNetworkDelegate() override;

// Initializes member variables used for overriding the proxy config.

@@ -161,7 +162,7 @@ class DataReductionProxyNetworkDelegate : public net::LayeredNetworkDelegate {

OnResolveProxyHandler on_resolve_proxy_handler_;

- ProxyConfigGetter proxy_config_getter_;

+ const DataReductionProxyConfigurator* configurator_;

DISALLOW_COPY_AND_ASSIGN(DataReductionProxyNetworkDelegate);

};