components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service.h - Issue 778463002: Wrapped data reduction proxy initialization into its own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service.h

Issue 778463002: Wrapped data reduction proxy initialization into its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@network-delegate

Patch Set: Addressed comment from mmenke Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/io_thread.cc ('K') | « components/data_reduction_proxy/core/browser/BUILD.gn ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service.h

index 49e56c4d1f20d2d68d7bd11f8252e599cc738940..e639b6ad7c5728913be6fe8227e043b6e7002735 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service.h

@@ -101,6 +101,7 @@ class DataReductionProxyConfigTracker : public DataReductionProxyConfigurator {

void Disable() override;

void AddHostPatternToBypass(const std::string& pattern) override;

void AddURLPatternToBypass(const std::string& pattern) override;

+ const net::ProxyConfig& GetProxyConfigOnIOThread() const override;

private:

FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigServiceTest,

@@ -114,6 +115,7 @@ class DataReductionProxyConfigTracker : public DataReductionProxyConfigurator {

const net::ProxyConfig& config);

base::Callback<void(bool, const net::ProxyConfig&)> update_proxy_config_;

+ net::ProxyConfig config_;

std::vector<std::string> bypass_rules_;

scoped_refptr<base::TaskRunner> task_runner_;