Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc

Issue 778463002: Wrapped data reduction proxy initialization into its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@network-delegate
Patch Set: Addressed comment from mmenke Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.h"
6
7 #include "base/bind.h"
8 #include "base/time/time.h"
9 #include "chrome/browser/net/chrome_net_log.h"
10 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator. h"
11 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
12 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_fact ory.h"
13 #include "chrome/browser/prefs/pref_service_syncable.h"
14 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_io_d ata.h"
15 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_stat istics_prefs.h"
16 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_event _store.h"
17
18 scoped_ptr<data_reduction_proxy::DataReductionProxyIOData>
19 CreateDataReductionProxyChromeIOData(
20 ChromeNetLog* net_log,
21 content::BrowserContext* browser_context,
22 PrefServiceSyncable* prefs,
23 const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
24 const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner,
25 DataReductionProxyChromeConfigurator** configurator) {
26 DCHECK(net_log);
27 DCHECK(prefs);
28 DCHECK(browser_context);
29 DataReductionProxyChromeSettings* settings =
30 DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
31 browser_context);
32
33 #if defined(OS_ANDROID) || defined(OS_IOS)
34 // On mobile we write data reduction proxy prefs directly to the pref service.
35 // On desktop we store data reduction proxy prefs in memory, writing to disk
36 // every 60 minutes and on termination. Shutdown hooks must be added for
37 // Android and iOS in order for non-zero delays to be supported.
38 // (http://crbug.com/408264)
39 base::TimeDelta commit_delay = base::TimeDelta();
40 #else
41 base::TimeDelta commit_delay = base::TimeDelta::FromMinutes(60);
42 #endif
43
44 // The event_store is used by DataReductionProxyChromeSettings, configurator,
45 // and ProfileIOData. Ownership is passed to the latter via
46 // ProfileIOData::Handle, which is only destroyed after
47 // BrowserContextKeyedServices, including DataReductionProxyChromeSettings.
48 data_reduction_proxy::DataReductionProxyEventStore*
49 data_reduction_proxy_event_store =
50 new data_reduction_proxy::DataReductionProxyEventStore(
51 ui_task_runner);
52
53 // The configurator is used by DataReductionProxyChromeSettings and
54 // ProfileIOData. Ownership is passed to the latter via ProfileIOData::Handle,
55 // which is only destroyed after BrowserContextKeyedServices,
56 // including DataReductionProxyChromeSettings.
57 // Retain a raw pointer to use for initialization of data reduction proxy
58 // settings after ownership is passed.
59 DataReductionProxyChromeConfigurator*
60 data_reduction_proxy_chrome_configurator =
61 new DataReductionProxyChromeConfigurator(
62 prefs,
63 io_task_runner,
64 net_log, data_reduction_proxy_event_store);
65
66 data_reduction_proxy::DataReductionProxyStatisticsPrefs*
67 data_reduction_proxy_statistics_prefs =
68 new data_reduction_proxy::DataReductionProxyStatisticsPrefs(
69 prefs, ui_task_runner,
70 commit_delay);
71
72 scoped_ptr<data_reduction_proxy::DataReductionProxyIOData>
73 data_reduction_proxy_data_io_data(
74 new data_reduction_proxy::DataReductionProxyIOData(
75 DataReductionProxyChromeSettings::GetClient(),
76 settings->params()->Clone(),
77 make_scoped_ptr(data_reduction_proxy_chrome_configurator),
78 make_scoped_ptr(data_reduction_proxy_statistics_prefs),
79 make_scoped_ptr(data_reduction_proxy_event_store),
80 settings,
81 io_task_runner,
82 ui_task_runner));
83 settings->SetDataReductionProxyStatisticsPrefs(
84 data_reduction_proxy_statistics_prefs);
85
86 *configurator = data_reduction_proxy_chrome_configurator;
87 return data_reduction_proxy_data_io_data.Pass();
88 }
89
90 scoped_ptr<data_reduction_proxy::DataReductionProxyIOData>
91 CreateDataReductionProxyChromeIODataForSystem(
92 ChromeNetLog* net_log,
93 PrefServiceSyncable* prefs,
94 const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
95 const scoped_refptr<base::SingleThreadTaskRunner>& ui_task_runner) {
96 // TODO(kundaji): Move flags initialization to DataReductionProxyParams and
97 // merge with flag initialization in
98 // data_reduction_proxy_chrome_settings_factory.cc.
99 int flags = data_reduction_proxy::DataReductionProxyParams::kAllowed |
100 data_reduction_proxy::DataReductionProxyParams::kFallbackAllowed |
101 data_reduction_proxy::DataReductionProxyParams::kAlternativeAllowed;
102 if (data_reduction_proxy::DataReductionProxyParams::
103 IsIncludedInPromoFieldTrial()) {
104 flags |= data_reduction_proxy::DataReductionProxyParams::kPromoAllowed;
105 }
106 if (data_reduction_proxy::DataReductionProxyParams::
107 IsIncludedInHoldbackFieldTrial()) {
108 flags |= data_reduction_proxy::DataReductionProxyParams::kHoldback;
109 }
110 scoped_ptr<data_reduction_proxy::DataReductionProxyIOData>
111 data_reduction_proxy_data_io_data(
112 new data_reduction_proxy::DataReductionProxyIOData(
113 DataReductionProxyChromeSettings::GetClient(),
114 make_scoped_ptr(
115 new data_reduction_proxy::DataReductionProxyParams(flags)),
116 scoped_ptr<
117 data_reduction_proxy::DataReductionProxyConfigurator>(),
118 scoped_ptr<
119 data_reduction_proxy::DataReductionProxyStatisticsPrefs>(),
120 scoped_ptr<data_reduction_proxy::DataReductionProxyEventStore>(),
121 nullptr,
122 io_task_runner,
123 ui_task_runner));
124 return data_reduction_proxy_data_io_data.Pass();
125 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698