Android: fixes out dir for adb_gdb with cr tool.

Android: fixes out dir for adb_gdb with cr tool.

Use the CHROMIUM_OUT_DIR variable when available.

BUG=
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237571

[bulach, 2013-11-20 13:35:16]

small tweak :)

[digit1, 2013-11-20 13:49:18]

https://codereview.chromium.org/77843003/diff/1/build/android/adb_gdb
File build/android/adb_gdb (right):

https://codereview.chromium.org/77843003/diff/1/build/android/adb_gdb#newcode254
build/android/adb_gdb:254: \$CHROMIUM_SRC/$CHROMIUM_OUT_DIR/Debug/lib.target/   
  (used by Make builds)
I believe this will get printed before detect_symbol_dir() has run, which means
it will not print the correct value if CHROMIUM_OUT_DIR is not defined.

What about doing the following instead:

- At the start of the script to:

    # Default value for CHROMIUM_OUT_DIR
    if [ -z "$CHROMIUM_OUT_DIR" ]; then
      CHROMIUM_OUT_DIR=out
    fi

- Add a --out=<name> option to specify an alternative ignores
  environment variables, that simply updates CHROMIUM_OUT_DIR.

- Update the documentation above with:

  The script tries to find the most recent version of the debug
  version of shared library under one of the following directories:

     \$CHROMIUM_SRC/<out>/Release/lib/
     \$CHROMIUM_SRC/<out>/Debug/lib
     ...

  Where <out> is 'out' by default, unless the --out=<name> option
  is used, or the CHROMIUM_OUT_DIR environment variable is defined.

[bulach, 2013-11-20 16:47:35]

thanks david! another look please?

https://codereview.chromium.org/77843003/diff/1/build/android/adb_gdb
File build/android/adb_gdb (right):

https://codereview.chromium.org/77843003/diff/1/build/android/adb_gdb#newcode254
build/android/adb_gdb:254: \$CHROMIUM_SRC/$CHROMIUM_OUT_DIR/Debug/lib.target/   
  (used by Make builds)
On 2013/11/20 13:49:18, digit1 wrote:
> I believe this will get printed before detect_symbol_dir() has run, which
means
> it will not print the correct value if CHROMIUM_OUT_DIR is not defined.
> 
> What about doing the following instead:
> 
> - At the start of the script to:
> 
>     # Default value for CHROMIUM_OUT_DIR
>     if [ -z "$CHROMIUM_OUT_DIR" ]; then
>       CHROMIUM_OUT_DIR=out
>     fi
> 
> - Add a --out=<name> option to specify an alternative ignores
>   environment variables, that simply updates CHROMIUM_OUT_DIR.
> 
> - Update the documentation above with:
> 
>   The script tries to find the most recent version of the debug
>   version of shared library under one of the following directories:
> 
>      \$CHROMIUM_SRC/<out>/Release/lib/
>      \$CHROMIUM_SRC/<out>/Debug/lib
>      ...
> 
>   Where <out> is 'out' by default, unless the --out=<name> option
>   is used, or the CHROMIUM_OUT_DIR environment variable is defined.

excellent idea! done.

[bulach, 2013-11-27 12:24:21]

ping? :)

[digit1, 2013-11-27 13:20:35]

Sorry, forgot about this one. Excellent change, lgtm, thanks :-)

[bulach, 2013-11-27 14:30:34]

thanks david! since this is a developer-only script, CQing with NOTRY..

[commit-bot: I haz the power, 2013-11-27 14:30:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/77843003/50001

[commit-bot: I haz the power, 2013-11-27 14:34:37]

Change committed as 237571