Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 778373003: remove device::clear -- no longer called (Closed)

Created:
6 years ago by reed2
Modified:
6 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove device::clear -- no longer called BUG=skia: Committed: https://skia.googlesource.com/skia/+/08c357c9142c68e1ec9493eb3d5aeacb41ccd7b5

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M include/core/SkDevice.h View 2 chunks +2 lines, -0 lines 0 comments Download
M include/device/xps/SkXPSDevice.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778373003/1
6 years ago (2014-12-07 20:13:34 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-07 20:13:34 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1367)
6 years ago (2014-12-07 20:17:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778373003/20001
6 years ago (2014-12-07 20:42:54 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-07 20:42:55 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years ago (2014-12-08 02:43:03 UTC) #10
reed1
lgtm
6 years ago (2014-12-08 15:59:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778373003/20001
6 years ago (2014-12-08 16:00:16 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-08 16:00:34 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/08c357c9142c68e1ec9493eb3d5aeacb41ccd7b5

Powered by Google App Engine
This is Rietveld 408576698