tools/metrics/histograms/histograms.xml - Issue 778243002: Push API: Return cached registration if available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 778243002: Push API: Return cached registration if available. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@store2

Patch Set: Add test, refactor and rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 84859fed502f94effaf0f3cf20a853d5d8b72226..836481a524f00490622c61896e5e33b504936fb2 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -53740,13 +53740,14 @@ To add a new entry, add it with any value and run test to compute valid value.

- <int value="1" label="Page has no active Service Worker"/>

- <int value="2" label="Push service not available"/>

- <int value="3" label="Registration limit reached"/>

- <int value="4" label="Permission denied"/>

- <int value="5" label="Push service error"/>

- <int value="6" label="No sender id provided"/>

- <int value="7" label="Storage error"/>

+ <int value="1" label="Successful (from cache)"/>

Ilya Sherman 2014/12/09 00:30:53 Is the is a subcase of case 0, or complementary?

johnme 2014/12/11 16:15:17 Done.

+ <int value="2" label="Page has no active Service Worker"/>

+ <int value="3" label="Push service not available"/>

+ <int value="4" label="Registration limit reached"/>

+ <int value="5" label="Permission denied"/>

+ <int value="6" label="Push service error"/>

+ <int value="7" label="No sender id provided"/>

+ <int value="8" label="Storage error"/>

</enum>