Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 778173002: NaCl cleanup: Use Bit('build_ARCH') instead of Bit('target_ARCH') (Closed)

Created:
6 years ago by Mark Seaborn
Modified:
6 years ago
Reviewers:
Derek Schuff
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Use Bit('build_ARCH') instead of Bit('target_ARCH') This removes some uses of Bit('target_ARCH'), the definitions of which have been removed from the NaCl side. BUG=https://code.google.com/p/nativeclient/issues/detail?id=2703 TEST=nacl_integration Committed: https://crrev.com/0f96f55c8c4c36374494808451bfb335cbef49b0 Cr-Commit-Position: refs/heads/master@{#307044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/native_client/chrome_main.scons View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
6 years ago (2014-12-05 16:46:00 UTC) #2
Derek Schuff
lgtm
6 years ago (2014-12-05 17:44:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778173002/1
6 years ago (2014-12-05 17:53:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 18:00:56 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-05 18:02:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f96f55c8c4c36374494808451bfb335cbef49b0
Cr-Commit-Position: refs/heads/master@{#307044}

Powered by Google App Engine
This is Rietveld 408576698