Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 778113002: [x86] Slow case of TruncateDoubleToI shouldn't be inline. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[x86] Slow case of TruncateDoubleToI shouldn't be inline. R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/5866c5c2f0fe9d7214f67634f2e55b94521a2ac3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -4 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +28 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
6 years ago (2014-12-05 08:38:28 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-05 08:38:52 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-05 09:28:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/778113002/1
6 years ago (2014-12-05 09:28:37 UTC) #5
Benedikt Meurer
6 years ago (2014-12-05 09:29:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5866c5c2f0fe9d7214f67634f2e55b94521a2ac3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698