Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: runtime/vm/intermediate_language_arm64.cc

Issue 778063002: Implement correct semantics of Boolean Conversion (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_arm64.cc
===================================================================
--- runtime/vm/intermediate_language_arm64.cc (revision 42124)
+++ runtime/vm/intermediate_language_arm64.cc (working copy)
@@ -24,6 +24,8 @@
namespace dart {
DECLARE_FLAG(bool, emit_edge_counters);
+DECLARE_FLAG(bool, enable_asserts);
+DECLARE_FLAG(bool, enable_type_checks);
DECLARE_FLAG(int, optimization_counter_threshold);
DECLARE_FLAG(bool, use_osr);
@@ -363,11 +365,18 @@
// Call the runtime if the object is not bool::true or bool::false.
ASSERT(locs->always_calls());
Label done;
- __ CompareObject(reg, Bool::True(), PP);
- __ b(&done, EQ);
- __ CompareObject(reg, Bool::False(), PP);
- __ b(&done, EQ);
+ if (FLAG_enable_type_checks) {
+ __ CompareObject(reg, Bool::True(), PP);
+ __ b(&done, EQ);
+ __ CompareObject(reg, Bool::False(), PP);
+ __ b(&done, EQ);
+ } else {
+ ASSERT(FLAG_enable_asserts);
+ __ CompareObject(reg, Object::null_instance(), PP);
+ __ b(&done, NE);
+ }
+
__ Push(reg); // Push the source object.
compiler->GenerateRuntimeCall(token_pos,
deopt_id,

Powered by Google App Engine
This is Rietveld 408576698