Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 7780016: Make Callback.Equals() only work when comparing against the same type. (Closed)

Created:
9 years, 3 months ago by awong
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org, darin (slow to review), akalin
Visibility:
Public.

Description

Make Callback.Equals() only work when comparing against the same type. Previously, we were using the base class's comparator to check equality, which allows us to make comparisons across callbacks of different types. This disallows such a thing. BUG=none TEST=New no-compile test.

Patch Set 1 #

Total comments: 2

Patch Set 2 : add missing file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -22 lines) Patch
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/bind_unittest.nc View 1 chunk +0 lines, -21 lines 0 comments Download
M base/callback.h View 7 chunks +28 lines, -0 lines 0 comments Download
M base/callback.h.pump View 1 chunk +4 lines, -0 lines 0 comments Download
M base/callback_internal.h View 1 chunk +1 line, -1 line 0 comments Download
A base/callback_unittest.nc View 1 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
awong
Okay, this is actually useful.
9 years, 3 months ago (2011-09-10 00:37:34 UTC) #1
willchan no longer on Chromium
http://codereview.chromium.org/7780016/diff/1/base/bind_unittest.nc File base/bind_unittest.nc (left): http://codereview.chromium.org/7780016/diff/1/base/bind_unittest.nc#oldcode82 base/bind_unittest.nc:82: Why are these getting deleted?
9 years, 3 months ago (2011-09-10 00:40:59 UTC) #2
awong
http://codereview.chromium.org/7780016/diff/1/base/bind_unittest.nc File base/bind_unittest.nc (left): http://codereview.chromium.org/7780016/diff/1/base/bind_unittest.nc#oldcode82 base/bind_unittest.nc:82: On 2011/09/10 00:40:59, willchan wrote: > Why are these ...
9 years, 3 months ago (2011-09-10 00:57:45 UTC) #3
willchan no longer on Chromium
LGTM
9 years, 3 months ago (2011-09-10 01:00:34 UTC) #4
awong
9 years, 3 months ago (2011-09-10 04:10:48 UTC) #5
On 2011/09/10 01:00:34, willchan wrote:
> LGTM

Committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=100564

Powered by Google App Engine
This is Rietveld 408576698