Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(211)

Issue 7780011: Merge 94793 - Crashes in WebCore::ReplaceSelectionCommand::doApply (Closed)

Created:
9 years, 1 month ago by sullivan
Modified:
9 years, 1 month ago
Reviewers:
sullivan
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94793 - Crashes in WebCore::ReplaceSelectionCommand::doApply https://bugs.webkit.org/show_bug.cgi?id=67762 Patch by Shinya Kawanaka <shinyak@google.com>; on 2011-09-08 Reviewed by Ryosuke Niwa. Source/WebCore: WebCore::enclosingBlock may return null, but its return value was not checked. This patch checks it. Tests: editing/inserting/insert-without-enclosing-block.html * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Added null check. LayoutTests: WebCore::enclosingBlock may return NULL, but its return value was not checked. This patch checks it. * editing/inserting/insert-without-enclosing-block-expected.txt: Added. * editing/inserting/insert-without-enclosing-block.html: Added. TBR=sullivan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + LayoutTests/editing/inserting/insert-without-enclosing-block.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/inserting/insert-without-enclosing-block-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/editing/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
sullivan
9 years, 1 month ago (2011-09-09 22:45:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698