Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 777993003: Add ProfileInfoCache::ProfileIsChild/IsLegacySupervisedAtIndex. (Closed)

Created:
6 years ago by Marc Treib
Modified:
6 years ago
CC:
chromium-reviews, rginda+watch_chromium.org, pam+watch_chromium.org, Patrick Nepper
Base URL:
https://chromium.googlesource.com/chromium/src.git@unicorn_upstream
Project:
chromium
Visibility:
Public.

Description

Add ProfileInfoCache::ProfileIsChild/IsLegacySupervisedAtIndex. Make sure there is always a non-LegacySupervised profile (it's okay if there is only a child profile!) TBRing since this has already been reviewed at https://chromereviews.googleplex.com/108027013/ TBR=bauerb@chromium.org TBR=noms@chromium.org BUG=372381 Committed: https://crrev.com/4887f082a62b414ef3a611eb58690240aed1c408 Cr-Commit-Position: refs/heads/master@{#307229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M chrome/browser/profiles/profile_info_cache.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_info_interface.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_service.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777993003/1
6 years ago (2014-12-08 11:39:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 12:37:26 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4887f082a62b414ef3a611eb58690240aed1c408 Cr-Commit-Position: refs/heads/master@{#307229}
6 years ago (2014-12-08 12:38:16 UTC) #4
Marc Treib
6 years ago (2014-12-08 12:48:46 UTC) #6
Message was sent while issue was closed.
Adding TBRed reviewers as actual reviewers, just fyi.

Powered by Google App Engine
This is Rietveld 408576698