Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: util/mach/mach_message_test.cc

Issue 777993002: MachMessageServer: eliminate argument redundancy (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/mach_message_test.cc
diff --git a/util/mach/mach_message_test.cc b/util/mach/mach_message_test.cc
index eed6c8e21820deaef30e10a2100bef89e7546c39..9877e2d1343dfc22f220abd999ef385cefd8f629 100644
--- a/util/mach/mach_message_test.cc
+++ b/util/mach/mach_message_test.cc
@@ -23,16 +23,21 @@ namespace test {
namespace {
TEST(MachMessage, MachMessageDeadlineFromTimeout) {
- MachMessageDeadline deadline_0 = MachMessageDeadlineFromTimeout(0);
- EXPECT_EQ(kMachMessageNonblocking, deadline_0);
+ MachMessageDeadline deadline_0 =
+ MachMessageDeadlineFromTimeout(kMachMessageTimeoutNonblocking);
+ EXPECT_EQ(kMachMessageDeadlineNonblocking, deadline_0);
+
+ deadline_0 =
+ MachMessageDeadlineFromTimeout(kMachMessageTimeoutWaitIndefinitely);
+ EXPECT_EQ(kMachMessageDeadlineWaitIndefinitely, deadline_0);
deadline_0 = MachMessageDeadlineFromTimeout(1);
MachMessageDeadline deadline_1 = MachMessageDeadlineFromTimeout(100);
- EXPECT_NE(kMachMessageNonblocking, deadline_0);
- EXPECT_NE(kMachMessageWaitIndefinitely, deadline_0);
- EXPECT_NE(kMachMessageNonblocking, deadline_1);
- EXPECT_NE(kMachMessageWaitIndefinitely, deadline_1);
+ EXPECT_NE(kMachMessageDeadlineNonblocking, deadline_0);
+ EXPECT_NE(kMachMessageDeadlineWaitIndefinitely, deadline_0);
+ EXPECT_NE(kMachMessageDeadlineNonblocking, deadline_1);
+ EXPECT_NE(kMachMessageDeadlineWaitIndefinitely, deadline_1);
EXPECT_GE(deadline_1, deadline_0);
}
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698