Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 777993002: MachMessageServer: eliminate argument redundancy (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

MachMessageServer: eliminate argument redundancy. MachMessageServer::Run()’s distinct |nonblocking| parameter is removed. The information it formerly conveyed is now implied by the |timeout_ms| parameter, which can accept two special values, kMachMessageTimeoutNonblocking and kMachMessageTimeoutWaitIndefinitely. TEST=client_test, snapshot_test, util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c874958fd0d5044631d126cd7274f9258fef275b

Patch Set 1 #

Patch Set 2 : Update man pages #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -112 lines) Patch
M client/simulate_crash_mac_test.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M snapshot/mac/mach_o_image_annotations_reader_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/catch_exception_tool.ad View 1 2 2 chunks +6 lines, -10 lines 0 comments Download
M tools/catch_exception_tool.cc View 1 2 8 chunks +15 lines, -15 lines 0 comments Download
M tools/on_demand_service_tool.ad View 1 2 1 chunk +1 line, -1 line 0 comments Download
M util/mach/child_port_handshake.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/exc_client_variants_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M util/mach/exception_ports_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M util/mach/mach_message.h View 4 chunks +24 lines, -9 lines 0 comments Download
M util/mach/mach_message.cc View 4 chunks +12 lines, -9 lines 0 comments Download
M util/mach/mach_message_server.h View 1 2 2 chunks +10 lines, -24 lines 0 comments Download
M util/mach/mach_message_server.cc View 2 chunks +7 lines, -14 lines 0 comments Download
M util/mach/mach_message_server_test.cc View 1 2 7 chunks +7 lines, -10 lines 0 comments Download
M util/mach/mach_message_test.cc View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This is a net code negative, which is a net positive!
6 years ago (2014-12-04 21:10:00 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-12-05 20:14:52 UTC) #3
Mark Mentovai
6 years ago (2014-12-10 16:11:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c874958fd0d5044631d126cd7274f9258fef275b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698