Issue 7779036: Force write of clean shutdown bit ASAP to try to help stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7779036: Force write of clean shutdown bit ASAP to try to help stats (Closed)

Created:
9 years, 3 months ago by jar (doing other things)

Modified:
9 years, 3 months ago

Reviewers:
rtenneti, wtc, abarth-chromium, eroman, tc, kerz_google, Scott Hess - ex-Googler

CC:
chromium-reviews, laforge, Mark Larson

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Force write of clean shutdown bit ASAP to try to help stats BUG=95375 r=rtenneti Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99664

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/metrics/metrics_service.cc	View	1	1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

I'm looking for a fast (holiday) review of this tiny fragment. I'm hoping we can ...

9 years, 3 months ago (2011-09-05 17:23:14 UTC) #1

kerz_google

On 2011/09/05 17:33:14, abarth wrote: > Seems worth a try. LGTM LGTM, let's just get ...

9 years, 3 months ago (2011-09-05 17:35:35 UTC) #3

wtc

9 years, 3 months ago (2011-09-06 17:44:22 UTC) #4

LGTM.

http://codereview.chromium.org/7779036/diff/3001/chrome/browser/metrics/metri...
File chrome/browser/metrics/metrics_service.cc (right):

http://codereview.chromium.org/7779036/diff/3001/chrome/browser/metrics/metri...
chrome/browser/metrics/metrics_service.cc:1483: // Redundant hack to write pref
ASAP.
Would be nice to say why you want to write pref ASAP.

Expand Messages | Collapse Messages