components/webdata_services/webdata_services_export.h - Issue 777863002: Introduce new component webdata_services

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/webdata_services/webdata_services_export.h

Issue 777863002: Introduce new component webdata_services (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary DEPS on //ui, sort dependencies Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_WEBDATA_SERVICES_WEBDATA_SERVICES_EXPORT_H_

	6 #define COMPONENTS_WEBDATA_SERVICES_WEBDATA_SERVICES_EXPORT_H_

	7

	8 #if defined(COMPONENT_BUILD)

	9 #if defined(WIN32)

	10

	11 #if defined(WEBDATA_SERVICES_IMPLEMENTATION)

	12 #define WEBDATA_SERVICES_EXPORT __declspec(dllexport)

	13 #else

	14 #define WEBDATA_SERVICES_EXPORT __declspec(dllimport)

	15 #endif // defined(WEBDATA_IMPLEMENTATION)
	Peter Kasting 2014/12/05 21:47:56 This comment doesn't match the actual #if above This comment doesn't match the actual #if above sdefresne 2014/12/08 10:54:42 Done. Show quoted text On 2014/12/05 at 21:47:56, Peter Kasting wrote: > This comment doesn't match the actual #if above Done.
	16

	17 #else // defined(WIN32)
	Peter Kasting 2014/12/05 21:47:56 Nit: Unlike comments on the endif, I think comment Nit: Unlike comments on the endif, I think comments on the else should reverse the condition, i.e.: #if FOO ... #else // !FOO ... #endif // FOO (2 places) sdefresne 2014/12/08 10:54:42 Done. Show quoted text On 2014/12/05 at 21:47:56, Peter Kasting wrote: > Nit: Unlike comments on the endif, I think comments on the else should reverse the condition, i.e.: > > #if FOO > ... > #else // !FOO > ... > #endif // FOO > > (2 places) Done.
	18 #if defined(WEBDATA_SERVICES_IMPLEMENTATION)

	19 #define WEBDATA_SERVICES_EXPORT __attribute__((visibility("default")))

	20 #else

	21 #define WEBDATA_SERVICES_EXPORT

	22 #endif

	23 #endif

	24

	25 #else // defined(COMPONENT_BUILD)

	26 #define WEBDATA_SERVICES_EXPORT

	27 #endif

	28

	29 #endif // COMPONENTS_WEBDATA_SERVICES_WEBDATA_SERVICES_EXPORT_H_

OLD	NEW

« components/webdata_services/web_data_service_wrapper.cc ('K') | « components/webdata_services/web_data_service_wrapper.cc ('k') | no next file » | no next file with comments »