Introduce new component webdata_services

chrome/browser/webdata/web_data_service_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WEBDATA_WEB_DATA_SERVICE_FACTORY_H__
 #define CHROME_BROWSER_WEBDATA_WEB_DATA_SERVICE_FACTORY_H__
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
-#include "base/memory/singleton.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
-#include "components/keyed_service/core/keyed_service.h"
-#include "components/webdata/common/web_database_service.h"
 
+template <typename T>
+struct DefaultSingletonTraits;

[Peter Kasting, 2014/12/05 21:47:56]

Please put this on the same line as above so it's clear the two are connected.

[sdefresne, 2014/12/08 10:54:42]

Done.

 class KeywordWebDataService;
 class TokenWebData;
+class WebDataServiceWrapper;
 
 #if defined(OS_WIN)
 class PasswordWebDataService;
 #endif
 
 namespace autofill {
+class AutofillWebDataBackend;
 class AutofillWebDataService;
 }  // namespace autofill
 
-// A wrapper of WebDataService so that we can use it as a profile keyed service.
-class WebDataServiceWrapper : public KeyedService {
- public:
-  explicit WebDataServiceWrapper(Profile* profile);
-
-  // For testing.
-  WebDataServiceWrapper();
-
-  ~WebDataServiceWrapper() override;
-
-  // KeyedService:
-  void Shutdown() override;
-
-  virtual scoped_refptr<autofill::AutofillWebDataService> GetAutofillWebData();
-
-  virtual scoped_refptr<KeywordWebDataService> GetKeywordWebData();
-
-  virtual scoped_refptr<TokenWebData> GetTokenWebData();
-
-#if defined(OS_WIN)
-  virtual scoped_refptr<PasswordWebDataService> GetPasswordWebData();
-#endif
-
- private:
-  scoped_refptr<WebDatabaseService> web_database_;
-
-  scoped_refptr<autofill::AutofillWebDataService> autofill_web_data_;
-  scoped_refptr<KeywordWebDataService> keyword_web_data_;
-  scoped_refptr<TokenWebData> token_web_data_;
-
-#if defined(OS_WIN)
-  scoped_refptr<PasswordWebDataService> password_web_data_;
-#endif
-
-  DISALLOW_COPY_AND_ASSIGN(WebDataServiceWrapper);
-};
+// Initialize syncable services on database thread.
+// (visible for testing)

[Peter Kasting, 2014/12/05 21:47:56]

Nit: Use sentences.  Perhaps "Exposed here for use in tests."

+void InitSyncableServicesOnDBThread(
+    scoped_refptr<autofill::AutofillWebDataService> autofill_web_data,
+    const base::FilePath& profile_path,
+    const std::string& app_locale,
+    autofill::AutofillWebDataBackend* autofill_backend);
 
 // Singleton that owns all WebDataServiceWrappers and associates them with
 // Profiles.
 class WebDataServiceFactory : public BrowserContextKeyedServiceFactory {
  public:
   // Returns the WebDataServiceWrapper associated with the |profile|.
   static WebDataServiceWrapper* GetForProfile(
       Profile* profile,
       Profile::ServiceAccessType access_type);
 
@@ skipping 35 matching lines @@
   content::BrowserContext* GetBrowserContextToUse(
       content::BrowserContext* context) const override;
   KeyedService* BuildServiceInstanceFor(
       content::BrowserContext* profile) const override;
   bool ServiceIsNULLWhileTesting() const override;
 
   DISALLOW_COPY_AND_ASSIGN(WebDataServiceFactory);
 };
 
 #endif  // CHROME_BROWSER_WEBDATA_WEB_DATA_SERVICE_FACTORY_H__