ui/gfx: Get rid of a few static variables from NativeTheme* type.

ui/gfx: Get rid of a few static variables from NativeTheme* type.

Change them to static pointers initialized lazy.

BUG=83856
TEST=None

R=davemoore@chromium.org

[DaveMoore, 2011-08-31 15:53:58]

Could you explain why you want to do this? If it's to reduce static
initializers, then this is unnecessary, as function static members already don't
create static initializers. If it's to move the memory from data pages to the
heap, I'm not sure why that's desirable.

[tfarina, 2011-08-31 19:00:34]

On 2011/08/31 15:53:58, DaveMoore wrote:
> Could you explain why you want to do this? If it's to reduce static
> initializers, then this is unnecessary, as function static members already
don't
> create static initializers. If it's to move the memory from data pages to the
> heap, I'm not sure why that's desirable.

Maybe there was a change, but the bug reports
gfx::NativeThemeLinux::instance()::s_native_theme.

[oshima, 2011-09-01 17:02:50]

Drive by comment.

Does this need to be thread safe? I believe it shouldn't be used by any thread
other than UI thread. If this indeed can be used by multiple threads, you need
to make theme object thread safe (it currently isn't).


On 2011/08/31 19:00:34, tfarina wrote:
> On 2011/08/31 15:53:58, DaveMoore wrote:
> > Could you explain why you want to do this? If it's to reduce static
> > initializers, then this is unnecessary, as function static members already
> don't
> > create static initializers. If it's to move the memory from data pages to
the
> > heap, I'm not sure why that's desirable.
> 
> Maybe there was a change, but the bug reports
> gfx::NativeThemeLinux::instance()::s_native_theme.