Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 777733002: Fixed notification time of SignInStateObserver.onSignedOut(). (Closed)

Created:
6 years ago by Joao da Silva
Modified:
6 years ago
Reviewers:
nyquist
CC:
chromium-reviews, aberent
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed notification time of SignInStateObserver.onSignedOut(). When a managed account signs out then there is a progress dialog while the profile data is being wiped. Any pending observers should only be notified that a sign out has completed once this process is done. This fixes a crash in the SigninTests because the ProgressDialog isn't getting properly dismissed before the test ends. BUG=436068 Committed: https://crrev.com/be4481d5b7e925c4cf9af2b6d02a70fea43463b9 Cr-Commit-Position: refs/heads/master@{#306662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Joao da Silva
Please see also the downstream fix at https://chrome-internal-review.googlesource.com/#/c/186756. @Tommy: PTAL @Anthony FYI Thanks!
6 years ago (2014-12-03 19:33:32 UTC) #2
nyquist
lgtm, thanks!
6 years ago (2014-12-03 19:37:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777733002/1
6 years ago (2014-12-03 19:44:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 20:22:19 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-03 20:23:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be4481d5b7e925c4cf9af2b6d02a70fea43463b9
Cr-Commit-Position: refs/heads/master@{#306662}

Powered by Google App Engine
This is Rietveld 408576698