LayoutTests/webmidi/requestmidiaccess.html - Issue 77773003: Make WebMIDI use blink Promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/webmidi/requestmidiaccess.html

Issue 77773003: Make WebMIDI use blink Promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/webmidi/permission-expected.txt ('k') | LayoutTests/webmidi/requestmidiaccess-expected.txt » ('j') | Source/modules/webmidi/MIDIAccess.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/webmidi/requestmidiaccess.html

diff --git a/LayoutTests/webmidi/requestmidiaccess.html b/LayoutTests/webmidi/requestmidiaccess.html

index 97f3a179bf714a5e5b8cdf9e07934426e60d531f..1e1285b9d142e6b41713818908f9b948b637467f 100644

--- a/LayoutTests/webmidi/requestmidiaccess.html

+++ b/LayoutTests/webmidi/requestmidiaccess.html

@@ -56,7 +56,7 @@ function successCallback1(a) {

shouldThrow('output.send([0xf1, 0x45, 0x7f])', '"SecurityError: Failed to execute \'send\' on \'MIDIOutput\': permission to send system exclusive messages is denied."');

// Now test System Exclusive access - our test mock should not allow this type of access.

- shouldNotThrow("navigator.requestMIDIAccess({sysex: true}).then(successCallback2, errorCallback2)");

+ navigator.requestMIDIAccess({sysex: true}).then(successCallback2, errorCallback2);

}

function errorCallback1(error) {

@@ -77,7 +77,7 @@ function errorCallback2(error) {

window.jsTestIsAsync = true;

// Test basic access, with no System Exclusive.

-shouldNotThrow("navigator.requestMIDIAccess().then(successCallback1, errorCallback1)");

+navigator.requestMIDIAccess().then(successCallback1, errorCallback1);

</script>

</body>

« no previous file with comments | « LayoutTests/webmidi/permission-expected.txt ('k') | LayoutTests/webmidi/requestmidiaccess-expected.txt » ('j') | Source/modules/webmidi/MIDIAccess.h » ('J')