LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html - Issue 77773003: Make WebMIDI use blink Promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html

Issue 77773003: Make WebMIDI use blink Promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html

diff --git a/LayoutTests/webmidi/requestmidiaccess-fail.html b/LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html

similarity index 52%

copy from LayoutTests/webmidi/requestmidiaccess-fail.html

copy to LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html

index 1baaedc91786a059725b7dedbe3d573359556086..8c7c718d52d229bd48c4a92d5e490b7a6004f0af 100644

--- a/LayoutTests/webmidi/requestmidiaccess-fail.html

+++ b/LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html

@@ -5,7 +5,7 @@

</head>

<body>

-description("Tests navigator.requestMIDIAccess failure.");

+description("Tests navigator.requestMIDIAccess fails in a detached frame.");

function successCallback(access) {

testFailed("requestMIDIAccess() does not fail unexpectedly.");

@@ -19,11 +19,16 @@ function errorCallback(error) {

finishJSTest();

}

-window.jsTestIsAsync = true;

+iframe = document.createElement('iframe');

+document.body.appendChild(iframe);

+contentNavigator = iframe.contentWindow.navigator;

+document.body.removeChild(iframe);

// set testRunner configuration so that requestMIDIAccess returns "InvalidStateError".

-testRunner.setMIDIAccessorResult(false);

-shouldNotThrow("navigator.requestMIDIAccess().then(successCallback, errorCallback)");

+contentNavigator.requestMIDIAccess().then(successCallback, errorCallback);

+// FIXME: errorCallback should be called, but due to the Blink Promise impelementation the

+// returned Promise never be resolved nor rejected.

+finishJSTest();

</script>

</body>