LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html - Issue 77773003: Make WebMIDI use blink Promise.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html

Issue 77773003: Make WebMIDI use blink Promise. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/webmidi/requestmidiaccess-fail-expected.txt ('k') | LayoutTests/webmidi/requestmidiaccess-in-detached-frame-expected.txt » ('j') | Source/modules/webmidi/MIDIAccess.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("Tests navigator.requestMIDIAccess failure.");	8 description("Tests navigator.requestMIDIAccess fails in a detached frame.");

9	9

10 function successCallback(access) {	10 window.jsTestIsAsync = true;

	11 iframe = document.createElement('iframe');

	12 document.body.appendChild(iframe);

	13 contentNavigator = iframe.contentWindow.navigator;

	14 document.body.removeChild(iframe);

	15

	16 // set testRunner configuration so that requestMIDIAccess returns "InvalidStateE rror".

	17 contentNavigator.requestMIDIAccess().then(function() {

11 testFailed("requestMIDIAccess() does not fail unexpectedly.");	18 testFailed("requestMIDIAccess() does not fail unexpectedly.");

12 finishJSTest();	19 finishJSTest();

13 }	20 }, function() {

14

15 function errorCallback(error) {

16 errorName = error.name;	21 errorName = error.name;

17 shouldBe("errorName", "'InvalidStateError'");	22 shouldBe("errorName", "'InvalidStateError'");

18 testPassed("requestMIDIAccess() fail as expected.");	23 testPassed("requestMIDIAccess() fail as expected.");

19 finishJSTest();	24 finishJSTest();

20 }	25 });

21	26 // FIXME: errorCallback should be called, but due to the Blink Promise impelemen tation the

22 window.jsTestIsAsync = true;	27 // returned Promise never be resolved nor rejected.

23	28 finishJSTest();

24 // set testRunner configuration so that requestMIDIAccess returns "InvalidStateE rror".

25 testRunner.setMIDIAccessorResult(false);

26 shouldNotThrow("navigator.requestMIDIAccess().then(successCallback, errorCallbac k)");

27	29

28 </script>	30 </script>

29 </body>	31 </body>

30 </html>	32 </html>

OLD	NEW