Make WebMIDI use blink Promise.

Source/modules/webmidi/MIDIAccess.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef MIDIAccess_h
 #define MIDIAccess_h
 
 #include "bindings/v8/ScriptWrappable.h"
 #include "core/dom/ActiveDOMObject.h"
 #include "core/events/EventTarget.h"
 #include "modules/webmidi/MIDIAccessor.h"
 #include "modules/webmidi/MIDIAccessorClient.h"
 #include "modules/webmidi/MIDIInput.h"
+#include "modules/webmidi/MIDIOptions.h"
 #include "modules/webmidi/MIDIOutput.h"
 #include "wtf/RefCounted.h"
 #include "wtf/RefPtr.h"
 #include "wtf/Vector.h"
 
 namespace WebCore {
 
 class ExecutionContext;
-class MIDIAccessPromise;
+class NavigatorWebMIDI;
 
 class MIDIAccess : public RefCounted<MIDIAccess>, public ScriptWrappable, public ActiveDOMObject, public EventTargetWithInlineData, public MIDIAccessorClient {
     REFCOUNTED_EVENT_TARGET(MIDIAccess);
 public:
     virtual ~MIDIAccess();
-    static PassRefPtr<MIDIAccess> create(ExecutionContext*, MIDIAccessPromise*);
+    static PassRefPtr<MIDIAccess> create(const MIDIOptions&, ExecutionContext*, NavigatorWebMIDI*);
 
     MIDIInputVector inputs() const { return m_inputs; }
     MIDIOutputVector outputs() const { return m_outputs; }
 
     DEFINE_ATTRIBUTE_EVENT_LISTENER(connect);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(disconnect);
 
     void setSysExEnabled(bool);
     bool sysExEnabled() const { return m_sysExEnabled; }
 
     // EventTarget
     virtual const AtomicString& interfaceName() const OVERRIDE { return EventTargetNames::MIDIAccess; }
     virtual ExecutionContext* executionContext() const OVERRIDE { return ActiveDOMObject::executionContext(); }
 
     // ActiveDOMObject
     virtual void stop();
 
     // MIDIAccessorClient
     virtual void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version) OVERRIDE;
     virtual void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version) OVERRIDE;
     virtual void didStartSession(bool success) OVERRIDE;
     virtual void didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp) OVERRIDE;
 
     // |timeStampInMilliseconds| is in the same time coordinate system as performance.now().
     void sendMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStampInMilliseconds);
 
+    void startRequest();
+
 private:
-    MIDIAccess(ExecutionContext*, MIDIAccessPromise*);
+    MIDIAccess(const MIDIOptions&, ExecutionContext*, NavigatorWebMIDI*);
 
-    void startRequest();
     virtual void permissionDenied();
 
+    NavigatorWebMIDI* m_navigator;

[abarth-chromium, 2013/12/03 16:57:57]

This raw pointer is concerning.  This object looks like it can live for an
arbitrary length of time yet it has a raw pointer to another object that can
live for an arbitrary amount of time.

[yhirano, 2013/12/04 05:20:24]

We need a holder that holds pending MIDIAccessors and I think NavigatorWebMIDI
is appropriate.
I simplified the interaction between NavigatorWebMIDI and MIDIAccessor and added
comments.
m_navigator will be cleared when it goes invalid.

     MIDIInputVector m_inputs;
     MIDIOutputVector m_outputs;
-    MIDIAccessPromise* m_promise;
 
     OwnPtr<MIDIAccessor> m_accessor;
+    MIDIOptions m_options;
     bool m_hasAccess;
     bool m_sysExEnabled;
     bool m_requesting;
 };
 
 } // namespace WebCore
 
 #endif // MIDIAccess_h