chrome/browser/ui/app_list/app_list_controller_delegate.cc - Issue 77773002: Ensure the ExtensionSystem is ready before initializing an ExtensionAppModelBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_controller_delegate.cc

Issue 77773002: Ensure the ExtensionSystem is ready before initializing an ExtensionAppModelBuilder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: System -> Service Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/ui/app_list/app_list_syncable_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_controller_delegate.cc

diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate.cc b/chrome/browser/ui/app_list/app_list_controller_delegate.cc

index e6bff3e771bcaadb6170e8bead66a9888fc27067..4b508b1b17fe4e251271a66085ef14c317188e4d 100644

--- a/chrome/browser/ui/app_list/app_list_controller_delegate.cc

+++ b/chrome/browser/ui/app_list/app_list_controller_delegate.cc

@@ -161,8 +161,7 @@ void AppListControllerDelegate::GetApps(Profile* profile,

ExtensionSet* out_apps) {

ExtensionService* service =

extensions::ExtensionSystem::Get(profile)->extension_service();

- if (!service)

- return;

+ DCHECK(service);

out_apps->InsertAll(*service->extensions());

out_apps->InsertAll(*service->disabled_extensions());

out_apps->InsertAll(*service->terminated_extensions());

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/ui/app_list/app_list_syncable_service.h » ('j') | no next file with comments »