chrome/browser/ui/app_list/app_list_syncable_service_factory.cc - Issue 77773002: Ensure the ExtensionSystem is ready before initializing an ExtensionAppModelBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_syncable_service_factory.cc

Issue 77773002: Ensure the ExtensionSystem is ready before initializing an ExtensionAppModelBuilder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix tests Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/app_list/app_list_syncable_service.cc ('K') | « chrome/browser/ui/app_list/app_list_syncable_service.cc ('k') | chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc » ('j') | chrome/chrome_tests_unit.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_syncable_service_factory.cc

diff --git a/chrome/browser/ui/app_list/app_list_syncable_service_factory.cc b/chrome/browser/ui/app_list/app_list_syncable_service_factory.cc

index 6799a9f8d7cfd295aac98df449c8ea787524779b..78ca1edc87cb06fb2890eb00b3cbbc257b992877 100644

--- a/chrome/browser/ui/app_list/app_list_syncable_service_factory.cc

+++ b/chrome/browser/ui/app_list/app_list_syncable_service_factory.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"

#include "base/prefs/pref_service.h"

+#include "chrome/browser/extensions/extension_system_factory.h"

#include "chrome/browser/profiles/incognito_helpers.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/app_list/app_list_syncable_service.h"

@@ -28,6 +29,7 @@ AppListSyncableServiceFactory::AppListSyncableServiceFactory()

: BrowserContextKeyedServiceFactory(

"AppListSyncableService",

BrowserContextDependencyManager::GetInstance()) {

+ DependsOn(extensions::ExtensionSystemFactory::GetInstance());

tapted 2013/11/20 11:03:25 note: This wasn't needed as part of the fix, but I

}

AppListSyncableServiceFactory::~AppListSyncableServiceFactory() {