Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Side by Side Diff: src/gpu/gl/GrGpuGL_program.cpp

Issue 777673003: move program descriptor generation to flush (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: more cleanup Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "GrGpuGL.h" 8 #include "GrGpuGL.h"
9 9
10 #include "builders/GrGLProgramBuilder.h" 10 #include "builders/GrGLProgramBuilder.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 SkDELETE(fEntries[i]); 84 SkDELETE(fEntries[i]);
85 } 85 }
86 fCount = 0; 86 fCount = 0;
87 } 87 }
88 88
89 int GrGpuGL::ProgramCache::search(const GrProgramDesc& desc) const { 89 int GrGpuGL::ProgramCache::search(const GrProgramDesc& desc) const {
90 ProgDescLess less; 90 ProgDescLess less;
91 return SkTSearch(fEntries, fCount, desc, sizeof(Entry*), less); 91 return SkTSearch(fEntries, fCount, desc, sizeof(Entry*), less);
92 } 92 }
93 93
94 GrGLProgram* GrGpuGL::ProgramCache::getProgram(const GrOptDrawState& optState, D rawType type) { 94 GrGLProgram* GrGpuGL::ProgramCache::getProgram(const GrOptDrawState& optState,
95 const GrProgramDesc& desc,
96 DrawType type) {
95 #ifdef PROGRAM_CACHE_STATS 97 #ifdef PROGRAM_CACHE_STATS
96 ++fTotalRequests; 98 ++fTotalRequests;
97 #endif 99 #endif
98 100
99 Entry* entry = NULL; 101 Entry* entry = NULL;
100 102
101 uint32_t hashIdx = optState.programDesc().getChecksum(); 103 uint32_t hashIdx = desc.getChecksum();
102 hashIdx ^= hashIdx >> 16; 104 hashIdx ^= hashIdx >> 16;
103 if (kHashBits <= 8) { 105 if (kHashBits <= 8) {
104 hashIdx ^= hashIdx >> 8; 106 hashIdx ^= hashIdx >> 8;
105 } 107 }
106 hashIdx &=((1 << kHashBits) - 1); 108 hashIdx &=((1 << kHashBits) - 1);
107 Entry* hashedEntry = fHashTable[hashIdx]; 109 Entry* hashedEntry = fHashTable[hashIdx];
108 if (hashedEntry && hashedEntry->fProgram->getDesc() == optState.programDesc( )) { 110 if (hashedEntry && hashedEntry->fProgram->getDesc() == desc) {
109 SkASSERT(hashedEntry->fProgram); 111 SkASSERT(hashedEntry->fProgram);
110 entry = hashedEntry; 112 entry = hashedEntry;
111 } 113 }
112 114
113 int entryIdx; 115 int entryIdx;
114 if (NULL == entry) { 116 if (NULL == entry) {
115 entryIdx = this->search(optState.programDesc()); 117 entryIdx = this->search(desc);
116 if (entryIdx >= 0) { 118 if (entryIdx >= 0) {
117 entry = fEntries[entryIdx]; 119 entry = fEntries[entryIdx];
118 #ifdef PROGRAM_CACHE_STATS 120 #ifdef PROGRAM_CACHE_STATS
119 ++fHashMisses; 121 ++fHashMisses;
120 #endif 122 #endif
121 } 123 }
122 } 124 }
123 125
124 if (NULL == entry) { 126 if (NULL == entry) {
125 // We have a cache miss 127 // We have a cache miss
126 #ifdef PROGRAM_CACHE_STATS 128 #ifdef PROGRAM_CACHE_STATS
127 ++fCacheMisses; 129 ++fCacheMisses;
128 #endif 130 #endif
129 GrGLProgram* program = GrGLProgramBuilder::CreateProgram(optState, type, fGpu); 131 GrGLProgram* program = GrGLProgramBuilder::CreateProgram(optState, desc, type, fGpu);
130 if (NULL == program) { 132 if (NULL == program) {
131 return NULL; 133 return NULL;
132 } 134 }
133 int purgeIdx = 0; 135 int purgeIdx = 0;
134 if (fCount < kMaxEntries) { 136 if (fCount < kMaxEntries) {
135 entry = SkNEW(Entry); 137 entry = SkNEW(Entry);
136 purgeIdx = fCount++; 138 purgeIdx = fCount++;
137 fEntries[purgeIdx] = entry; 139 fEntries[purgeIdx] = entry;
138 } else { 140 } else {
139 SkASSERT(fCount == kMaxEntries); 141 SkASSERT(fCount == kMaxEntries);
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 } 196 }
195 } 197 }
196 ++fCurrLRUStamp; 198 ++fCurrLRUStamp;
197 return entry->fProgram; 199 return entry->fProgram;
198 } 200 }
199 201
200 //////////////////////////////////////////////////////////////////////////////// 202 ////////////////////////////////////////////////////////////////////////////////
201 203
202 #define GL_CALL(X) GR_GL_CALL(this->glInterface(), X) 204 #define GL_CALL(X) GR_GL_CALL(this->glInterface(), X)
203 205
204 bool GrGpuGL::flushGraphicsState(const GrOptDrawState& optState, DrawType type) { 206 bool GrGpuGL::flushGraphicsState(const GrOptDrawState& optState,
207 const GrProgramDesc& desc,
208 DrawType type) {
205 // GrGpu::setupClipAndFlushState should have already checked this and bailed if not true. 209 // GrGpu::setupClipAndFlushState should have already checked this and bailed if not true.
206 SkASSERT(optState.getRenderTarget()); 210 SkASSERT(optState.getRenderTarget());
207 211
208 if (kStencilPath_DrawType == type) { 212 if (kStencilPath_DrawType == type) {
209 const GrRenderTarget* rt = optState.getRenderTarget(); 213 const GrRenderTarget* rt = optState.getRenderTarget();
210 SkISize size; 214 SkISize size;
211 size.set(rt->width(), rt->height()); 215 size.set(rt->width(), rt->height());
212 this->glPathRendering()->setProjectionMatrix(optState.getViewMatrix(), s ize, rt->origin()); 216 this->glPathRendering()->setProjectionMatrix(optState.getViewMatrix(), s ize, rt->origin());
213 } else { 217 } else {
214 this->flushMiscFixedFunctionState(optState); 218 this->flushMiscFixedFunctionState(optState);
215 219
216 GrBlendCoeff srcCoeff = optState.getSrcBlendCoeff(); 220 GrBlendCoeff srcCoeff = optState.getSrcBlendCoeff();
217 GrBlendCoeff dstCoeff = optState.getDstBlendCoeff(); 221 GrBlendCoeff dstCoeff = optState.getDstBlendCoeff();
218 222
219 fCurrentProgram.reset(fProgramCache->getProgram(optState, type)); 223 fCurrentProgram.reset(fProgramCache->getProgram(optState, desc, type));
220 if (NULL == fCurrentProgram.get()) { 224 if (NULL == fCurrentProgram.get()) {
221 SkDEBUGFAIL("Failed to create program!"); 225 SkDEBUGFAIL("Failed to create program!");
222 return false; 226 return false;
223 } 227 }
224 228
225 fCurrentProgram.get()->ref(); 229 fCurrentProgram.get()->ref();
226 230
227 GrGLuint programID = fCurrentProgram->programID(); 231 GrGLuint programID = fCurrentProgram->programID();
228 if (fHWProgramID != programID) { 232 if (fHWProgramID != programID) {
229 GL_CALL(UseProgram(programID)); 233 GL_CALL(UseProgram(programID));
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 GrGLAttribTypeToLayout(attribType).fNormalized, 299 GrGLAttribTypeToLayout(attribType).fNormalized,
296 stride, 300 stride,
297 reinterpret_cast<GrGLvoid*>(vertexOffsetInBytes + o ffset)); 301 reinterpret_cast<GrGLvoid*>(vertexOffsetInBytes + o ffset));
298 offset += attribs[attribIndex].fOffset; 302 offset += attribs[attribIndex].fOffset;
299 } 303 }
300 attribState->disableUnusedArrays(this, usedAttribArraysMask); 304 attribState->disableUnusedArrays(this, usedAttribArraysMask);
301 } 305 }
302 } 306 }
303 307
304 void GrGpuGL::buildProgramDesc(const GrOptDrawState& optState, 308 void GrGpuGL::buildProgramDesc(const GrOptDrawState& optState,
305 const GrProgramDesc::DescInfo& descInfo,
306 GrGpu::DrawType drawType, 309 GrGpu::DrawType drawType,
307 GrProgramDesc* desc) { 310 GrProgramDesc* desc) {
308 if (!GrGLProgramDescBuilder::Build(optState, descInfo, drawType, this, desc) ) { 311 if (!GrGLProgramDescBuilder::Build(optState, drawType, this, desc)) {
309 SkDEBUGFAIL("Failed to generate GL program descriptor"); 312 SkDEBUGFAIL("Failed to generate GL program descriptor");
310 } 313 }
311 } 314 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698