src/effects/SkXfermodeImageFilter.cpp - Issue 777643003: use ClipOp instead of SkRegion for clipping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkXfermodeImageFilter.cpp

Issue 777643003: use ClipOp instead of SkRegion for clipping (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkXfermodeImageFilter.cpp

diff --git a/src/effects/SkXfermodeImageFilter.cpp b/src/effects/SkXfermodeImageFilter.cpp

index 1618b640360a1369bfb08eefe19061d0a73a4eca..82bc2df64d8b23cf6f67725e82703a54c4860ec0 100644

--- a/src/effects/SkXfermodeImageFilter.cpp

+++ b/src/effects/SkXfermodeImageFilter.cpp

@@ -89,7 +89,7 @@ bool SkXfermodeImageFilter::onFilterImage(Proxy* proxy,

paint.setXfermode(fMode);

canvas.drawBitmap(foreground, SkIntToScalar(foregroundOffset.fX),

SkIntToScalar(foregroundOffset.fY), &paint);

- canvas.clipRect(SkRect::Make(foregroundBounds), SkRegion::kDifference_Op);

+ canvas.clipRect(SkRect::Make(foregroundBounds), kDifference_SkClipOp);

paint.setColor(SK_ColorTRANSPARENT);

canvas.drawPaint(paint);

*dst = device->accessBitmap(false);

« no previous file with comments | « src/core/SkRecordDraw.cpp ('k') | src/pipe/SkGPipeRead.cpp » ('j') | no next file with comments »