Check whether the marking deque overflowed in ProcessEphemeralMarking

src/heap/mark-compact.cc

Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index 27d257980f281c9067d264f8e239bda5d198a481..3fd9e255c5b9bcd27a1ca304c95683b31b0bf1d8 100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -2099,7 +2099,7 @@ void MarkCompactCollector::ProcessEphemeralMarking(
       MarkImplicitRefGroups();
     }
     ProcessWeakCollections();
-    work_to_do = !marking_deque_.IsEmpty();
+    work_to_do = !marking_deque_.IsEmpty() || marking_deque_.overflowed();

[Erik Corry, 2014/12/03 12:46:21]

It would be better to improve MarkCompactCollector::IsMarkingStackEmpty() to
include both these conditions and then use it here and in the DCHECK above. 
There are also about 5 places in incremental-marking.cc that check for an empty
stack, and at least some of them should use this check instead.

I see Hannes just moved that function, so maybe it should be changed in its new
location (incremental-marking.somthing)

[Hannes Payer (out of office), 2014/12/03 13:18:24]

Let's do that.

     ProcessMarkingDeque();
   }
 }