Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 777633002: Removing explicit include dir, bindings/core/v8, for the webcore_testing target (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
Reviewers:
vivekg, Nico
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing explicit include dir, bindings/core/v8, for the webcore_testing target BUG=236119 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/core.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
vivekg
While going thr' some of the bindings related bugs stumbled upon this one. I verified ...
6 years ago (2014-12-03 13:54:04 UTC) #2
Nico
lgtm
6 years ago (2014-12-03 15:54:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777633002/1
6 years ago (2014-12-03 16:04:16 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-03 16:06:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186434

Powered by Google App Engine
This is Rietveld 408576698