src/mips/lithium-codegen-mips.cc - Issue 77763006: MIPS: Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFrom…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/lithium-codegen-mips.cc

Issue 77763006: MIPS: Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFrom… (Closed) Base URL: https://github.com/v8/v8.git@gbl

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/lithium-codegen-mips.cc

diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc

index f3b0ff65db54fed4dc16da98529312f7b0a8027b..377702bdb4537ea96f849ae37fbdd02b6ecf8a6a 100644

--- a/src/mips/lithium-codegen-mips.cc

+++ b/src/mips/lithium-codegen-mips.cc

@@ -257,7 +257,7 @@ bool LCodeGen::GenerateDeferredCode() {

__ MultiPush(cp.bit() | fp.bit() | ra.bit());

__ li(scratch0(), Operand(Smi::FromInt(StackFrame::STUB)));

__ push(scratch0());

- __ Addu(fp, sp, Operand(2 * kPointerSize));

+ __ Addu(fp, sp, Operand(StandardFrameConstants::kFixedFrameSizeFromFp));

Comment(";;; Deferred code");

}

code->Generate();

@@ -309,7 +309,7 @@ bool LCodeGen::GenerateDeoptJumpTable() {

ASSERT(info()->IsStub());

__ li(scratch0(), Operand(Smi::FromInt(StackFrame::STUB)));

__ push(scratch0());

- __ Addu(fp, sp, Operand(2 * kPointerSize));

+ __ Addu(fp, sp, Operand(StandardFrameConstants::kFixedFrameSizeFromFp));

__ Call(t9);

}

} else {

« no previous file with comments | « src/mips/frames-mips.h ('k') | src/mips/macro-assembler-mips.cc » ('j') | no next file with comments »