src/mips/codegen-mips.cc - Issue 77763006: MIPS: Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFrom…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/codegen-mips.cc

Issue 77763006: MIPS: Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFrom… (Closed) Base URL: https://github.com/v8/v8.git@gbl

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/codegen-mips.cc

diff --git a/src/mips/codegen-mips.cc b/src/mips/codegen-mips.cc

index 904a37df267d514f1499d685d9d6605cba477fcb..221a0e1b4e2a81e01bc6cf5a93fdd0007d2b8469 100644

--- a/src/mips/codegen-mips.cc

+++ b/src/mips/codegen-mips.cc

@@ -618,7 +618,8 @@ static byte* GetNoCodeAgeSequence(uint32_t* length) {

CodePatcher patcher(byte_sequence, kNoCodeAgeSequenceLength);

patcher.masm()->Push(ra, fp, cp, a1);

patcher.masm()->nop(Assembler::CODE_AGE_SEQUENCE_NOP);

- patcher.masm()->Addu(fp, sp, Operand(2 * kPointerSize));

+ patcher.masm()->Addu(fp, sp,

+ Operand(StandardFrameConstants::kFixedFrameSizeFromFp));

initialized = true;

}

return byte_sequence;

« no previous file with comments | « src/mips/builtins-mips.cc ('k') | src/mips/frames-mips.h » ('j') | no next file with comments »