Issue 777573002: ChildPortHandshake: 10.6 fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 777573002: ChildPortHandshake: 10.6 fix (Closed)

Created:
6 years ago by Mark Mentovai

Modified:
6 years ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

ChildPortHandshake: 10.6 fix. The F_SETNOSIGPIPE fcntl() command is not available on 10.6. Use socketpair() instead of pipe(), so that the SO_NOSIGPIPE socket option can be used. TEST=util_test ChildPortHandshake.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8593b1aa55edf45e961b8a50b403e6bfbeab4d68

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	util/mach/child_port_handshake.cc	View	1 2	4 chunks	+17 lines, -4 lines	0 comments	Download

Total messages: 6 (3 generated)

Mark Mentovai

6 years ago (2014-12-03 18:42:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:80001) manually as
8593b1aa55edf45e961b8a50b403e6bfbeab4d68 (presubmit successful).