Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3654)

Unified Diff: chrome/browser/web_applications/web_app_mac.h

Issue 777543002: Create hosted app shims on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed unnecessary forward declaration Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app_mac.h
diff --git a/chrome/browser/web_applications/web_app_mac.h b/chrome/browser/web_applications/web_app_mac.h
index 7c2ff41676a066303c52b8f4fd74904a9396c338..e1962d03efb5008707b7a59bd58b93a524fe18d3 100644
--- a/chrome/browser/web_applications/web_app_mac.h
+++ b/chrome/browser/web_applications/web_app_mac.h
@@ -66,15 +66,27 @@ class WebAppShortcutCreator {
void DeleteShortcuts();
bool UpdateShortcuts();
+ // Show the bundle we just generated in the Finder.
+ virtual void RevealAppShimInFinder() const;
+
+ // Reveals app shim in finder given a profile and app.
+ // Calls RevealAppShimInFinderForAppOnFileThread and schedules it
+ // on the FILE thread.
+ static void RevealAppShimInFinderForApp(Profile* profile,
jackhou1 2014/12/04 06:37:11 This can just be in web_app:: rather than web_app:
mitchellj 2014/12/04 22:48:40 Done.
+ const extensions::Extension* app);
+
+ // Reveals app shim in finder given a profile and app.
+ // This is executed on the FILE thread.
+ static void RevealAppShimInFinderForAppOnFileThread(
jackhou1 2014/12/04 06:37:11 This can just be in the anonymous namespace in web
mitchellj 2014/12/04 22:48:40 Done.
+ const ShortcutInfo& shortcut_info,
+ const base::FilePath& app_path);
+
protected:
// Returns a path to an app bundle with the given id. Or an empty path if no
// matching bundle was found.
// Protected and virtual so it can be mocked out for testing.
virtual base::FilePath GetAppBundleById(const std::string& bundle_id) const;
- // Show the bundle we just generated in the Finder.
- virtual void RevealAppShimInFinder() const;
-
private:
FRIEND_TEST_ALL_PREFIXES(WebAppShortcutCreatorTest, DeleteShortcuts);
FRIEND_TEST_ALL_PREFIXES(WebAppShortcutCreatorTest, UpdateIcon);

Powered by Google App Engine
This is Rietveld 408576698