Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 777533005: Update cpplint.py to r141. (Closed)

Created:
6 years ago by Alex Vakulenko (Google)
Modified:
6 years ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools@master
Project:
tools
Visibility:
Public.

Description

Update cpplint.py to r141. This just a copy of cpplint.py from upstream [1]. [1] https://code.google.com/p/google-styleguide/source/detail?spec=svn141&r=141 The change in gclient_scm.py is to address a presubmit check error which was introduced by https://codereview.chromium.org/227163002 "print_func" parameter was being passed to a function instead of the object constructor. BUG=None NOTRY=True Change-Id: I4dca890d5f02957ddae33c4bd4269fd37758be3d Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293276

Patch Set 1 #

Patch Set 2 : Fixed pylint issue in fix_encoding (slice index is not an int) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -172 lines) Patch
M cpplint.py View 42 chunks +348 lines, -169 lines 0 comments Download
M fix_encoding.py View 1 1 chunk +1 line, -1 line 0 comments Download
M gclient_scm.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777533005/1
6 years ago (2014-12-05 00:40:49 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-05 00:40:51 UTC) #4
Alex Vakulenko (Google)
Re-submitting the cpplint change. Presubmit checks on the CL are failing due to the new ...
6 years ago (2014-12-05 00:43:54 UTC) #6
M-A Ruel
humm, I thought I had fixed gclient_scm. Oh well, lgtm.
6 years ago (2014-12-05 00:54:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777533005/1
6 years ago (2014-12-05 05:09:28 UTC) #9
commit-bot: I haz the power
Presubmit check for 777533005-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-05 05:11:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777533005/20001
6 years ago (2014-12-05 16:20:49 UTC) #13
commit-bot: I haz the power
Presubmit check for 777533005-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-05 16:22:54 UTC) #15
M-A Ruel
See https://codereview.chromium.org/723283003/.
6 years ago (2014-12-05 16:25:06 UTC) #16
Alex Vakulenko (Google)
On 2014/12/05 16:25:06, M-A Ruel wrote: > See https://codereview.chromium.org/723283003/. Ok, so how does it help ...
6 years ago (2014-12-05 16:30:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/777533005/20001
6 years ago (2014-12-05 22:17:54 UTC) #19
commit-bot: I haz the power
6 years ago (2014-12-05 22:19:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293276

Powered by Google App Engine
This is Rietveld 408576698