Source/modules/notifications/Notification.cpp - Issue 777483004: Bind Window focus ability to the ExecutionContext instead of the process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.cpp

Issue 777483004: Bind Window focus ability to the ExecutionContext instead of the process. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerClient.cpp » ('j') | public/web/WebScopedWindowFocusAllowedIndicator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/Notification.cpp

diff --git a/Source/modules/notifications/Notification.cpp b/Source/modules/notifications/Notification.cpp

index 6c0587fff8cb74e626169073a0388e791b290785..e99ad4809356b208e2740ad8a88dd2a5a53275de 100644

--- a/Source/modules/notifications/Notification.cpp

+++ b/Source/modules/notifications/Notification.cpp

@@ -33,9 +33,9 @@

#include "bindings/core/v8/ScriptWrappable.h"

#include "core/dom/Document.h"

+#include "core/dom/ScopedWindowFocusAllowedIndicator.h"

#include "core/events/Event.h"

#include "core/frame/UseCounter.h"

-#include "core/page/WindowFocusAllowedIndicator.h"

#include "modules/notifications/NotificationOptions.h"

#include "modules/notifications/NotificationPermissionClient.h"

#include "public/platform/Platform.h"

@@ -128,7 +128,7 @@ void Notification::dispatchShowEvent()

void Notification::dispatchClickEvent()

{

UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);

- WindowFocusAllowedIndicator windowFocusAllowed;

+ ScopedWindowFocusAllowedIndicator windowFocusAllowed(executionContext());

dispatchEvent(Event::create(EventTypeNames::click));

}