Issue 77743002: Rename *AttributeGetter => *OriginSafeMethodGetter and DomainSafeFunctionSetter => OriginSafeMethod…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 77743002: Rename AttributeGetter => OriginSafeMethodGetter and DomainSafeFunctionSetter => OriginSafeMethod… (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)

Modified:
7 years, 1 month ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename *AttributeGetter => *OriginSafeMethodGetter and DomainSafeFunctionSetter => OriginSafeMethodSetter Renaming for [CheckSecurity]. TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162348

Patch Set 1 #

Patch Set 2 : Domain => Origin #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -21 lines)			Patch
	M	Source/bindings/scripts/code_generator_v8.pm	View	1	5 chunks	+8 lines, -8 lines	0 comments	Download
	M	Source/bindings/tests/results/V8TestCheckSecurityInterface.cpp	View	1	7 chunks	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/77743002/1

7 years, 1 month ago (2013-11-20 07:09:01 UTC) #2

haraken

LGTM Per the cross-origin security policy, let's rename "DomainSafe" to "OriginSafe". I should have mentioned ...

7 years, 1 month ago (2013-11-20 07:36:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/77743002/120001

7 years, 1 month ago (2013-11-20 07:48:13 UTC) #4

Message was sent while issue was closed.

Change committed as 162348